Label individual size, margin, and origin fields#2288
Merged
colinator27 merged 1 commit intoUnderminersTeam:masterfrom Dec 18, 2025
Merged
Label individual size, margin, and origin fields#2288colinator27 merged 1 commit intoUnderminersTeam:masterfrom
colinator27 merged 1 commit intoUnderminersTeam:masterfrom
Conversation
|
Download the artifacts for this pull request here: GUI:
CLI: |
Member
|
Looks good to me. I think it's probably acceptable for the worse look when it's shrunk horizontally, because you can still tell what it's supposed to mean from just a few letters. Not sure if there's a way to get breakpoints set up properly... Besides that, I wonder if we also want to rename "Margin" to something like "BBox" (for bounding box), since that's the terminology GameMaker itself uses. |
colinator27
approved these changes
Dec 18, 2025
Member
colinator27
left a comment
colinator27
left a comment
There was a problem hiding this comment.
I guess we can figure out whether we want to rename "Margin" in the future, but this is a welcome improvement in the meantime. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor change to the sprite editor to clarify the width, height, and each margin side.
Caveats
Looks worse than the current solution at extremely wide (too much empty space) and extremely narrow (cropped text, too-small fields) tool scales.
Notes
Suggested by HalfBreadChaos in the Underminers server.