Rename RoomEntryFlags.ShowColor to RoomEntryFlags.ClearViewBackground, Name GraphTypeEnum values in UndertaleAnimationCurve#2257
Merged
colinator27 merged 4 commits intoUnderminersTeam:masterfrom Dec 18, 2025
Conversation
|
Download the artifacts for this pull request here: GUI:
CLI: |
yokimklein
changed the title
colinator27
approved these changes
Dec 18, 2025
Member
colinator27
left a comment
colinator27
left a comment
There was a problem hiding this comment.
Looks good, thanks! I made one additional fix for where ShowColor was still being used in a script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RoomEntryFlags.ShowColoruses an inaccurate placeholder name. I've replaced it with the name of the flag used in the GMS2 IDE.UndertaleAnimationCurve.GraphTypeEnumuses placeholder unknown names, I've named these based on the enum from the GMAssetCompiler.Caveats
Any code using the old names will need to be updated to use the new ones.