Add missing header chunk flag, correct save location flag name, Name unknown fields in options#2252
Merged
BenjaminUrquhart merged 2 commits intoUnderminersTeam:masterfrom Oct 1, 2025
Merged
Conversation
|
Download the artifacts for this pull request here: GUI:
CLI: |
BenjaminUrquhart
requested changes
Oct 1, 2025
yokimklein
changed the title
BenjaminUrquhart
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The header chunk flag
LocalDataEnabledis a misnomer, enabling it tells the engine to use the%appdata%directory to write save data instead of%localappdata%. I've proposed changing the name toUseAppDataSaveLocationinstead with a comment to clarify its behaviour.I've named two unknown fields in the options chunk,
ShaderExtensionFlagandShaderExtensionVersion, and added them to the GUI. I've also removed an unknown field from the GUI which is only used for padding.I've also discovered a flag on the LTS branch of GMS2 which we don't have, which is set when launching the game via the IDE's 'run' or 'debug' buttons. Additionally the SteamEnabled flag also seems to be enabled under something called the YoYoPlayer. I'm not entirely sure what this is, but I've added it to the flag's description.
Caveats
Any scripts referencing the old flag name
LocalDataEnabledwill need to be updated to useUseAppDataSaveLocationinstead.