Use actual tileset size for automatic room grid size calculation#2155
Merged
colinator27 merged 2 commits intoUnderminersTeam:masterfrom Jun 22, 2025
Merged
Use actual tileset size for automatic room grid size calculation#2155colinator27 merged 2 commits intoUnderminersTeam:masterfrom
colinator27 merged 2 commits intoUnderminersTeam:masterfrom
Conversation
|
Download the artifacts for this pull request here: GUI:
CLI: |
VladiStep
reviewed
Jun 21, 2025
colinator27
approved these changes
Jun 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(alt title: Fix incorrect calculated grid sizes in rooms with GMS2 tile layers)
Description
Previously, the automatic grid size calculation (if there's no global grid size set) determined the tile size by dividing the room size by the size of the tile layer in tiles, instead of using the tile width/height properties present on the tileset.
This doesn't work properly if a GMS2 tile layer isn't the exact same size as the room, which can happen through UTMT editing or through an extra row/column getting added for non-tile-size-divisible room sizes; for instance see
tower_1in Pizza Tower, which should have a grid size of 32x32 but is 31x31.This PR fixes that.
Caveats
Didn't test much.
Notes