Code search name filter.#2152
Conversation
|
I just wondering what Copilot will suggest |
There was a problem hiding this comment.
Pull Request Overview
Adds a code-name filter to the search window, updates the layout to a flexible grid, and truncates long code lines in the results.
- Introduce “Filter by code name” UI and logic in the search routine
- Switch layout to a Grid with an Expander for name filtering
- Truncate displayed lines to 128 characters with an ellipsis
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SearchInCodeWindow.xaml.cs | Added name‐filter fields and logic; reorganized fields; truncated long lines in results |
| SearchInCodeWindow.xaml | Converted to Grid layout; added Expander and name‐filter controls; updated Search button styling |
Comments suppressed due to low confidence (3)
UndertaleModTool/Windows/SearchInCodeWindow.xaml.cs:106
- [nitpick] The error message capitalizes 'Regex' here but earlier messages use lowercase 'regex'; consider standardizing the case for consistency across messages.
this.ShowError($"Invalid Regex: {e.Message}");
UndertaleModTool/Windows/SearchInCodeWindow.xaml.cs:92
- New name‐filter functionality is introduced; consider adding unit or integration tests to verify filtering by name (literal vs. regex, case sensitivity).
bool filterByName = FilterByNameExpander.IsExpanded;
UndertaleModTool/Windows/SearchInCodeWindow.xaml:47
- FontSize in WPF XAML should be a unitless numeric value; remove the "px" suffix and use FontSize="16" to prevent parse errors.
<UndertaleModTool:ButtonDark x:Name="SearchButton" Grid.Row="1" Content="Search" Width="68" Margin="0,5,0,0" FontSize="16px"
|
Download the artifacts for this pull request here: GUI:
CLI: |
|
Cool but why is the search button text huge |
Because I think it was too small for such a button (especially when there's a second row with the name filter) |
|
I'm fine making the Search button larger, but maybe the font size shouldn't be so large in comparison to the rest of the text. |
|
Done. (the wrong UTMT icon is because of Visual Studio Code) |
colinator27
left a comment
colinator27
left a comment
There was a problem hiding this comment.
Tested locally and seems to work well!
Description
Closes #2149, and fixes (partially) #2150.
Also, the code search window layout is flexible now.
Updated: since the second sub-issue of #2150 (disassembly new line inconsistency) was fixed, then this fixes #2150.
Caveats
None?