feat: Making some scripts crossplatforms#2125
Merged
colinator27 merged 23 commits intoUnderminersTeam:masterfrom May 31, 2025
Merged
feat: Making some scripts crossplatforms#2125colinator27 merged 23 commits intoUnderminersTeam:masterfrom
colinator27 merged 23 commits intoUnderminersTeam:masterfrom
Conversation
Adds a new method in the IScriptInterface to save files
|
Download the artifacts for this pull request here: GUI:
CLI: |
colinator27
requested changes
May 30, 2025
Member
colinator27
left a comment
colinator27
left a comment
There was a problem hiding this comment.
Overall, this looks really good! I just have a few questions and small things that will need corrections before being merged. Once those are done, I'll also make some formatting changes of my own, for consistency with the rest of the codebase. Thanks!
Removing uncessary things, and a silly gaffe
UndertaleModTests couldn't be built because it hadn't implemented PromptSaveFile
colinator27
approved these changes
May 31, 2025
Member
colinator27
left a comment
colinator27
left a comment
There was a problem hiding this comment.
I got a little bit carried away with fixing up the sound/mask scripts while I was fixing some formatting there, but I think everything is good now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes some scripts crossplatfrom
NewTextureRepacker, ExportAllStringsBetter, ImportAllStringsBetter, ImportASound and FindNullsInOffsetMap by removing WinForms use.
ImportMask and ImportFontData by using ImageMagick instead of System.Drawing.
UndertaleDialogSimulator, FindObjectsinRoom, CopySound, GameOjectCopy, GameOjectCopyInternal, ImportSoundsBulk, SpriteOriginCopy, ExportSpritesAsGIF and ImportGraphics_Full_Repack by removing unecessary "using windows_only_api" statements.
NOTE
I also added a method to the IScriptInterface to save files. Called "PromptSaveFile"