Merged
Conversation
Member
Author
|
Also forgot to mention, but this also resolves #2079. |
|
Download the artifacts for this pull request here: GUI:
CLI: |
Member
Author
|
Going to merge this in now as it seems low-risk (tested save/load on my suite of test games), and so that dependent PRs won't have conflict issues down the line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleans up
UndertaleSequence, changing out some technically undefined behavior ofDictionaryto use regular lists, and also adding some basic documentation (though still incomplete for certain fields that I don't fully understand).Caveats
Potential incompatibility with existing code relying on sequence structures, although these changes should be easy to adapt to. This has been tested on my regular set of games for save/load regressions.
Notes
I also modified the
Alignmethods inUndertaleReader/UndertaleWriterto no longer accept a padding byte other than 0, because it was unused and had some incorrect logic associated.Support was also added for
GMAudioEffectTrack, which acts just like a track with real keyframes for our purposes.