Add "Restore to defaults" button to (de)compiler settings window#2114
Merged
colinator27 merged 4 commits intoUnderminersTeam:masterfrom Apr 29, 2025
Merged
Add "Restore to defaults" button to (de)compiler settings window#2114colinator27 merged 4 commits intoUnderminersTeam:masterfrom
colinator27 merged 4 commits intoUnderminersTeam:masterfrom
Conversation
it ONLY resets the options shown on the window, not all settings
|
Download the artifacts for this pull request here: GUI:
CLI: |
Member
|
Maybe the settings could be rewritten at some point, but at least right now, the Other than that, I think I'm good with no confirmation for now, because it's not that many settings to change if you do accidentally click it for some reason. |
Member
|
I also just rewrote the logic so that the decompiler settings instance is reused, rather than created from scratch. Otherwise, the updated settings may not go into effect until the next time a data file is loaded. |
colinator27
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2112
Description
exactly what it says on the tin
Caveats
There's no confirmation. IDK whether there should be one or not (it should be easy to add). Also, the way it resets the settings might be a bit hacky (because I don't feel like PropertyChanged-ing), but It seems to work.
Notes