Remember window state when the program is closed#2088
Remember window state when the program is closed#2088colinator27 merged 5 commits intoUnderminersTeam:masterfrom
Conversation
|
Download the artifacts for this pull request here: GUI:
CLI: |
|
But WPF windows have necessary properties that are not read only ( |
|
Oh, and |
|
@VladiStep Just using that doesn't deal with some edge cases such as multiple monitors (apparently), so instead of dealing with all of that manually I think it's simpler to use the built in Windows functions. |
colinator27
left a comment
colinator27
left a comment
There was a problem hiding this comment.
Seems to work well on two monitors, and even when disconnecting one of them, it didn't seem to meaningfully break in any way.
Two things, though: Probably want to fix the indentation a bit, and also make this an optional setting (since I know at least personally, I sometimes have multiple tools open and don't want them interfering in the placement of new ones). I guess it can default to being on, though?
|
@colinator27 I'm not sure you mean by the indentation. To be honest I'm not sure what indentation is supposed to be used on the project. I added the setting but it's weird that this causes you problems since all settings are in one file for all instances of UTMT, so you'd think you'd have run into problems sooner. |
|
For context on indentation, I mean the bottom of Also, I haven't actually run into any problems with this yet, not sure what you're referring to there. |
|
Sorry, I guess I misunderstood, I guess you meant that you just want multiple instances appearing in different places? And about the indentation, I didn't see anything weird on the GitHub diffs, and VS makes it hard to notice this kind of thing. Put everything to spaces, hopefully this works out. |
|
Indentation looks good now, thanks! Also, I'm not expecting this to handle more than one window state at a time, that seems pretty infeasible... I think the setting as it is now is good. I'm fine with this PR as long as nobody else has any objections (probably want someone other than myself to review it as well). |
3 participants
Description
Add a field on the settings file to store the current state (position, size, if maximized) of the main window so it can be restored when you load the program back again. It uses the Windows functions SetWindowPlacement and GetWindowPlacement, which should be fault proof. I'm not storing some properties because they don't seem necessary.
Deals with #2085
Caveats
I haven't tested this on multiple monitors because I just have one... would appreciate if someone could test this.
Notes
I renamed MessageBoxExtensions to WindowExtensions and put the code there to not create a bunch more files (not sure if this should be done)