UndertaleModCli: Saving fix when replacing larger older file#2063
Merged
colinator27 merged 1 commit intoUnderminersTeam:masterfrom Mar 19, 2025
Merged
Conversation
|
Download the artifacts for this pull request here: GUI:
CLI: |
colinator27
approved these changes
Mar 19, 2025
Member
colinator27
left a comment
colinator27
left a comment
There was a problem hiding this comment.
Looks good to me - I'll make some small changes to formatting (and to how the file is moved, even in the existing GUI implementation) after merging, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, when saving and replacing an older data file with UndertaleModCli, if the older data file was bigger, UndertaleModCli would not truncate it down to the new size, causing it to have extra data at the end. Both GameMaker and UndertaleModTool seem reject loading data files with leftover data.
This PR modifies how UndertaleModCli saves to be more in line with UndertaleModTool, using a temp file which replaces the original older file if saving was successful.
Caveats
Notes