Another TouchControlsEnabler fix(sorry)#2058
Merged
colinator27 merged 2 commits intoUnderminersTeam:masterfrom Mar 19, 2025
Merged
Another TouchControlsEnabler fix(sorry)#2058colinator27 merged 2 commits intoUnderminersTeam:masterfrom
colinator27 merged 2 commits intoUnderminersTeam:masterfrom
Conversation
|
Download the artifacts for this pull request here: GUI:
CLI: |
Member
|
Hmm... Has this actually been tested on some varying mobile device/monitor resolutions? Want to make sure that this doesn't negatively affect anything accidentally before merging it in. |
Contributor
Author
|
I would test it now, thx for answer |
Now scr_add_keys() deletes old keys, and issue with display_set_gui_size() was fixed.
Contributor
Author
|
I tested it on the Deltarune(used booker's port as a base for test), and it works, but in deltarune for some reason(maybe other gui scale) text in the settings wasn't scaled right. But it dont influes on the game. |
colinator27
approved these changes
Mar 19, 2025
Member
colinator27
left a comment
colinator27
left a comment
There was a problem hiding this comment.
Looks good, then. Thank you! Feel free to make further PRs if any other issues arise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why i did this PR? I found that i was made an issue, while was trying to make this script work more stable, and im doing this to fix it. What kind of issue? I forgot to change scaling offset for the vertical part of controlers. So, visual interface was worked fine, but controls wasnt on their right spots technicaly. I fixed that now. Also, i deleted part, that was checked if user's device is mobile, because its useless, and could be dissapointing. So, now script should hopefully work more stable.
Caveats
For some reason, on NXTALE version of Undertale, controls doesnt takes the right scale. But, i think it should work fine on mobile devices, because screen size would be different.
Notes
Now touchcontrols should work more stable. But i think if game would change the gui size, controllers wouldn't take their correct spots technicaly. I dont know any sort of examples now.
Tests:
Tests was made on destkop version of the UT Yellow(gms 2023) and Undertale(gms 1.0.6)
