Underanalyzer: Fix incorrect data type in tiles#2037
Merged
colinator27 merged 2 commits intoUnderminersTeam:underanalyzerfrom Feb 12, 2025
Merged
Underanalyzer: Fix incorrect data type in tiles#2037colinator27 merged 2 commits intoUnderminersTeam:underanalyzerfrom
colinator27 merged 2 commits intoUnderminersTeam:underanalyzerfrom
Conversation
This commit changes the data type of SourceX and SourceY inside of the UndertaleRoom.Tile class to be integers instead of unsigned integers to allow for negative numbers.
|
Download the artifacts for this pull request here: GUI:
CLI: |
Member
|
Going to try retargeting this to master, but we'll see if things go horribly wrong or not. |
Member
|
Nope, that was disaster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
changes the data type of SourceX and SourceY inside of the UndertaleRoom.Tile class to be integers instead of unsigned integers to allow for negative numbers.
Caveats
Theres a chance that I missed a point in which the variable is used, which should be ironed out with more testing.
Notes
This was mostly a quick fix for an issue a friend found in Undertale Yellow.