Skip to content

Add settings to change transparency colors#1995

Merged
colinator27 merged 3 commits intoUnderminersTeam:masterfrom
luizzeroxis:set-transparency-colors
Jan 20, 2025
Merged

Add settings to change transparency colors#1995
colinator27 merged 3 commits intoUnderminersTeam:masterfrom
luizzeroxis:set-transparency-colors

Conversation

@luizzeroxis
Copy link
Copy Markdown
Contributor

Description

Add two textboxes where you can change the colors of the transparency grid behind sprites, backgrounds, etc. Depending on that game, the default colors can make it hard to see, so it's useful to be able to change it.

image

Closes #117

Caveats

None

Notes

None

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 20, 2024

@VladiStep
Copy link
Copy Markdown
Member

VladiStep commented Dec 20, 2024

Finally, nice!
I have only two suggestions:

  1. There should be : in the setting title - "Transparency grid colors:".
  2. IMO, the default color string should contain uppercase letters (FF instead of ff).

@luizzeroxis
Copy link
Copy Markdown
Contributor Author

@VladiStep

Thanks, I didn't put a colon because the other textboxes on this screen and throughout the program don't seem to have it. I agree with the capitalization thing.

Copy link
Copy Markdown
Member

@colinator27 colinator27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although in some future PR we may want to add a "restore default" settings, and/or color pickers. Low priority from a development standpoint, though.

@colinator27 colinator27 merged commit a1edc32 into UnderminersTeam:master Jan 20, 2025
@luizzeroxis luizzeroxis deleted the set-transparency-colors branch March 19, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Custom transparent color

3 participants