Merged
Conversation
|
Download the artifacts for this pull request here: GUI:
CLI: |
colinator27
approved these changes
Jan 20, 2025
Member
colinator27
left a comment
colinator27
left a comment
There was a problem hiding this comment.
Tested locally and looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a FlagsBox that display all possible flag values of a field as checkboxes. They are hidden in an Expander initially to not create clutter. The TextBox, as it existed before, is still there, so the old method of changing flags still works. If there's unrecognized flags, it'll display the number, and the checkboxes won't override it, simply adding or removing flags normally.
The FlagsBox was added to general info, the sound editor and the room editor.
Example:
Caveats
Alright, the Expander is a bit a ugly. But what isn't ugly in this, huh? I tried a ComboBox design, but modifying these built in controls is complicated.
Notes
Fixes #75.