Clean up some warnings and errors#1894
Merged
colinator27 merged 5 commits intomasterfrom Jan 20, 2025
Merged
Conversation
|
Download the artifacts for this pull request here: GUI:
CLI: |
Miepee
requested changes
Sep 3, 2024
UndertaleModTool/Windows/FindReferencesTypesDialog/UndertaleResourceReferenceMethodsMap.cs
Show resolved
Hide resolved
Miepee
reviewed
Dec 2, 2024
| @@ -1,3 +1,5 @@ | |||
| #pragma warning disable CA1416 // Validate platform compatibility | |||
Contributor
There was a problem hiding this comment.
instead of throwing this into every file, wonder if it makes more sense to put itinto the project.
Member
Author
There was a problem hiding this comment.
I think I would prefer it to only be used when absolutely necessary, rather than giving us the opportunity to accidentally write non-cross-platform code where we don't expect it.
Member
Author
|
Reviews seem pretty much resolved, and I want to take advantage of the warnings when merging the next batch of PRs, so I'll go ahead and merge this for now. For certain style things, we can certainly change them later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR checks have been plagued with tons of warning messages at the end (at least with GitHub's beta "Unchanged files with check annotations"), so this PR aims to get rid of a bunch of them.
Caveats
WebClientwas replaced withHttpClient, so there may be slight behavioral differences. I did test the updater, though, and it functioned fine.Some files now have
#pragmadirectives to disable cross-platform compatibility warnings, but I limited this specifically to GUI, which is already Windows-only, at least as it stands.Notes
Starting this as a draft to make sure the warnings no longer show up in the build pipeline.This seems to have worked.