Skip to content

Room editor temp pr#1489

Merged
colinator27 merged 6 commits intoUnderminersTeam:masterfrom
AwfulNasty:RoomEditorTempPR
Mar 20, 2025
Merged

Room editor temp pr#1489
colinator27 merged 6 commits intoUnderminersTeam:masterfrom
AwfulNasty:RoomEditorTempPR

Conversation

@AwfulNasty
Copy link
Copy Markdown
Contributor

Allows for middle click to be used to drag around the room canvas.

Clicking within the edge of a room object allows it to be resized by dragging once the object has been selected.

Description

General improved motion allowing for improved ease of use.

Pressing and holding middle click allows for the room canvas to be scrolled around, as well as for the margins to be expanded upon reaching the edge, allowing for areas previously out of bounds to be edited.

Once a room object is selected, clicking on it again near the edge will allow it to be dragged and resized (shift to increment by 0.5 or ctrl to increment by 0.1 in scale respectively).

Changes the control key to function more like a removal from any grid snapping (1x1), shift functions as it did before.

Pressing X/Y will flip selected object (invert X/Y scale)

Caveats

This is a draft - while the canvas dragging feels fine, attempting to resize some objects will freak out and grow exponentially.
Generally, drag resizing objects is the only really buggy part. I think it may be best to redo a lot of it and make it more like resizing in gamemaker studio, where the margins of the selected object's sprite are shown in an outline when it's clicked - that would probably make the math for resizing a bit more reliable as well.

Notes

I don't believe that I included any previous room editor changes that I made in separate PRs (making new room create code with the + button, stopping camera from returning to origin when objects are deleted), but if those are still in this feel free to tell me to get rid of them.

Thanks!

AwfulNasty and others added 4 commits September 21, 2023 22:54
Allows for middle click to be used to drag around the room canvas.

Clicking within the edge of a room object allows it to be resized by dragging once the object has been selected.
row was added unnecessarily
pixels
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2025

Copy link
Copy Markdown
Member

@colinator27 colinator27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made some changes and fixes to this, and I think it's ready to be merged in for full testing. Thanks!

@colinator27 colinator27 merged commit 42a17b9 into UnderminersTeam:master Mar 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants