fix: default to genesis block as the last base block

UdjinM6 · UdjinM6 · commit 422a695e2c30 · 2025-04-04T00:20:37.000+03:00
diff --git a/src/llmq/snapshot.cpp b/src/llmq/snapshot.cpp
@@ -392,11 +392,12 @@ bool BuildQuorumRotationInfo(CDeterministicMNManager& dmnman, CQuorumSnapshotMan
 uint256 GetLastBaseBlockHash(Span<const CBlockIndex*> baseBlockIndexes, const CBlockIndex* blockIndex,
                              bool use_legacy_construction)
 {
-    uint256 hash;
     if (!use_legacy_construction) {
         std::sort(baseBlockIndexes.begin(), baseBlockIndexes.end(),
                   [](const CBlockIndex* a, const CBlockIndex* b) { return a->nHeight < b->nHeight; });
     }
+    // default to genesis block
+    uint256 hash{Params().GenesisBlock().GetHash()};
     for (const auto baseBlock : baseBlockIndexes) {
         if (baseBlock->nHeight >= blockIndex->nHeight)
             break;

Original file line number	Diff line number	Diff line change
`@@ -392,11 +392,12 @@ bool BuildQuorumRotationInfo(CDeterministicMNManager& dmnman, CQuorumSnapshotMan`
`392`	`392`	`uint256 GetLastBaseBlockHash(Span<const CBlockIndex> baseBlockIndexes, const CBlockIndex blockIndex,`
`393`	`393`	`bool use_legacy_construction)`
`394`	`394`	`{`
`395`		`- uint256 hash;`
`396`	`395`	`if (!use_legacy_construction) {`
`397`	`396`	`std::sort(baseBlockIndexes.begin(), baseBlockIndexes.end(),`
`398`	`397`	`[](const CBlockIndex* a, const CBlockIndex* b) { return a->nHeight < b->nHeight; });`
`399`	`398`	`}`
	`399`	`+ // default to genesis block`
	`400`	`+ uint256 hash{Params().GenesisBlock().GetHash()};`
`400`	`401`	`for (const auto baseBlock : baseBlockIndexes) {`
`401`	`402`	`if (baseBlock->nHeight >= blockIndex->nHeight)`
`402`	`403`	`break;`