Repository navigation
Commit 5b60677
committed
test_runner: do not name-filter test file wrappers
Since run() applies testNamePatterns and testSkipPatterns to the root
test configuration under isolation 'none', the file level test that
wraps the single spawned process in watch mode is filtered by name
itself. Its name is empty, so any name pattern filtered it out and no
test ever ran. The same happens on the CLI with
`--test --watch --test-isolation=none --test-name-pattern=...`.
Exempt file wrappers from name filtering, as is already done for tag
filtering: the patterns are applied to the tests inside of the file by
the child process.
Refs: nodejs#64359
Refs: nodejs#62269
Signed-off-by: uditDewan <[email protected]>1 parent c9eed87 commit 5b60677
2 files changed
Lines changed: 28 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
314 | 320 | | |
315 | 321 | | |
316 | 322 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
216 | 238 | | |
217 | 239 | | |
218 | 240 | | |
| |||
0 commit comments