fix: make GroqOptionalParameters fields optional
#859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftnext
approved these changes
Dec 24, 2025
Collaborator
ftnext
left a comment
ftnext
left a comment
There was a problem hiding this comment.
Thank you for telling me.
By default all keys in a
TypedDictare required. This behaviour can be overridden by setting the dictionary’stotalparameter asFalse.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a type-checking error by making all fields in the GroqOptionalParameters TypedDict optional. Without this change, type checkers would report missing argument errors when calling the recognize function without providing all parameters defined in the TypedDict.
Key Changes:
- Added
total=Falseparameter toGroqOptionalParametersTypedDict class to make all fields optional
Comments suppressed due to low confidence (1)
speech_recognition/recognizers/whisper_api/groq.py:28
- The test coverage for optional parameters is missing. While there's a basic test, it doesn't verify that any of the optional parameters (prompt, response_format, temperature, language) can actually be passed to the recognize function. Consider adding test cases similar to test_openai.py (tests/recognizers/whisper_api/test_openai.py) which includes tests for language and prompt parameters.
class GroqOptionalParameters(TypedDict, total=False):
"""Groq speech transcription's optional parameters.
https://console.groq.com/docs/speech-text#transcription-endpoint-usage
"""
prompt: str
response_format: str
temperature: float
language: str
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ftnext
changed the title
GroqOptionalParameters fields optional
This was referenced Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this such errors might be seen.
Missing argument
promptin function `speech_recognition.recognizers.whisper_api.groq.recognize[missing-argument]