Skip to content

Drop deprecated code and revise log handling#347

Merged
bl-young merged 19 commits intorecursive-refacfrom
recursive_drop_code
May 4, 2023
Merged

Drop deprecated code and revise log handling#347
bl-young merged 19 commits intorecursive-refacfrom
recursive_drop_code

Conversation

@bl-young
Copy link
Copy Markdown
Contributor

@bl-young bl-young commented May 3, 2023

  • old code for flowbysector.py is dropped
  • deprecated functions are removed (primarily in validation.py, dataclean.py, fbs_allocation.py)
  • data_source_script cleaning functions which now use more general approaches have been removed (e.g., BEA.py
  • temp_data_source_functions.py have been moved to appropriate scripts
  • logging functions are moved to flowsa_log.py (from settings.py) and duplicate code removed
    • log files are enabled for FBA and FBS (to be refined in future)

@bl-young bl-young requested a review from catherinebirney May 3, 2023 20:35
Copy link
Copy Markdown
Contributor

@catherinebirney catherinebirney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good, this can be pulled in

@bl-young bl-young merged commit c2eeaab into recursive-refac May 4, 2023
@bl-young bl-young deleted the recursive_drop_code branch May 10, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants