Updates to FBA and FBS testing#251
Merged
catherinebirney merged 4 commits intodevelopfrom Jul 15, 2022
Merged
Conversation
3 tasks
Closed
Contributor
|
These changes are great! Do the FBS differences in the CNHW, CRHW, and TRI_DMR FBS make sense to you? The changes in the FBS are the same changes popping up in the QWI PR and none of the code changes in either of these PR should impact the FBS results. The changes in the state water FBS make sense because we modified the output sector level. |
Contributor
Author
I still need to look a bit more closely |
Contributor
Author
|
Ok yes CNHW reflects the disaggregated utilities sector (just like Water) |
Contributor
|
Ah ok, great. I will post the v1.2.3 FBS to Data Commons so we stop seeing these differences. |
catherinebirney
approved these changes
Jul 15, 2022
This was referenced Jul 15, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves all items in #249