Skip to content

Updates to FBA and FBS testing#251

Merged
catherinebirney merged 4 commits intodevelopfrom
gh_actions
Jul 15, 2022
Merged

Updates to FBA and FBS testing#251
catherinebirney merged 4 commits intodevelopfrom
gh_actions

Conversation

@bl-young
Copy link
Copy Markdown
Contributor

resolves all items in #249

@bl-young bl-young linked an issue Jul 15, 2022 that may be closed by this pull request
3 tasks
@bl-young bl-young requested a review from catherinebirney July 15, 2022 01:03
@bl-young bl-young mentioned this pull request Jul 15, 2022
@catherinebirney
Copy link
Copy Markdown
Contributor

These changes are great! Do the FBS differences in the CNHW, CRHW, and TRI_DMR FBS make sense to you? The changes in the FBS are the same changes popping up in the QWI PR and none of the code changes in either of these PR should impact the FBS results.

The changes in the state water FBS make sense because we modified the output sector level.

@bl-young
Copy link
Copy Markdown
Contributor Author

Do the FBS differences in the CNHW, CRHW, and TRI_DMR FBS make sense to you?

I still need to look a bit more closely

@bl-young
Copy link
Copy Markdown
Contributor Author

Ok yes CNHW reflects the disaggregated utilities sector (just like Water)
CRHW and TRI_DMR reflect minor changes in stewi source data introduced prior to v1.2.2 #234 (comment)

@catherinebirney
Copy link
Copy Markdown
Contributor

Ah ok, great. I will post the v1.2.3 FBS to Data Commons so we stop seeing these differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updates to testing for improved clarity

2 participants