Skip to content

update pandas requirement to 1.4.0 and Python to >=3.8#244

Merged
catherinebirney merged 2 commits intodevelopfrom
pandas_update
Jul 15, 2022
Merged

update pandas requirement to 1.4.0 and Python to >=3.8#244
catherinebirney merged 2 commits intodevelopfrom
pandas_update

Conversation

@catherinebirney
Copy link
Copy Markdown
Contributor

@catherinebirney catherinebirney commented Jul 11, 2022 •
edited
Loading

  • update pandas requirement from 1.3.2 to 1.4.0
  • drop support for testing FLOWSA package on Python 3.7
  • addresses issues discussed in Discussion 237 and Issue 328

@catherinebirney catherinebirney changed the title update pandas requirement to 1.4.0 update pandas requirement to 1.4.0 and Python to >=3.8 Jul 11, 2022
@catherinebirney
Copy link
Copy Markdown
Contributor Author

catherinebirney commented Jul 11, 2022

@matthewlchambers @bl-young

@bl-young
Copy link
Copy Markdown
Contributor

bl-young commented Jul 11, 2022

I don't know if this is the right way to go or not, but would it be worth specifying the minimum python version in setup.py?
https://stackoverflow.com/a/48777286, or anywhere else for that matter

@catherinebirney
Copy link
Copy Markdown
Contributor Author

catherinebirney commented Jul 11, 2022 •
edited
Loading

@bl-young I was thinking the same. We do have the 3.7 requirement listed in the wiki, but might not be an obvious place to look

@matthewlchambers matthewlchambers marked this pull request as ready for review July 11, 2022 22:23
@matthewlchambers matthewlchambers marked this pull request as draft July 11, 2022 22:23
@bl-young bl-young added this to the v1.2.3 milestone Jul 13, 2022
@catherinebirney catherinebirney marked this pull request as ready for review July 14, 2022 20:48
@catherinebirney
Copy link
Copy Markdown
Contributor Author

catherinebirney commented Jul 15, 2022

See PR #251 for explanation on FBS differences

@catherinebirney catherinebirney marked this pull request as draft July 15, 2022 14:34
@catherinebirney catherinebirney marked this pull request as ready for review July 15, 2022 14:35
@catherinebirney catherinebirney merged commit 16f5297 into develop Jul 15, 2022
@catherinebirney catherinebirney deleted the pandas_update branch July 15, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.2.3

Development

Successfully merging this pull request may close these issues.

2 participants

@catherinebirney @bl-young