Conversation
…ppdirs returns; join paths using pathlib's '/' operator instead of string '+' joins; minor edits: use f-strings for formatting/concatenation and use single quotes for non-docstring strings
This was referenced May 11, 2023
This was referenced May 11, 2023
catherinebirney
approved these changes
May 15, 2023
Contributor
catherinebirney
left a comment
catherinebirney
left a comment
There was a problem hiding this comment.
Code works on my end, thanks @bl-young
We should consider adding support for Python 3.11
Contributor
Author
Yep agreed, I think we can implement that throughout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_paths_if_missing()deprecated and replaced bymkdir_if_missing()