Skip to content

Implement better function handling#46

Merged
bl-young merged 6 commits intocedafrom
ceda_issue_45
Dec 3, 2024
Merged

Implement better function handling#46
bl-young merged 6 commits intocedafrom
ceda_issue_45

Conversation

@bl-young
Copy link
Copy Markdown
Contributor

@bl-young bl-young commented Dec 2, 2024

Resolves issue #45

@bl-young
Copy link
Copy Markdown
Contributor Author

bl-young commented Dec 2, 2024

@cclin130 could you confirm this works for the CEDA data?

# elif source == "foo":
source_fxn = config.get('process_function').split('/')
try:
module = __import__(source_fxn[0])
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very cool, TIL __import___

@cclin130
Copy link
Copy Markdown
Contributor

cclin130 commented Dec 2, 2024

@bl-young I'll pull the branch and give it a try

@cclin130
Copy link
Copy Markdown
Contributor

cclin130 commented Dec 3, 2024

@bl-young I pulled this branch and re-generated the import shares and import factors. On top of confirming everything runs, I checked the 2022 CEDA values and they are identical to what I had previously 🎉

@bl-young bl-young merged commit 4dc29c9 into ceda Dec 3, 2024
@bl-young bl-young deleted the ceda_issue_45 branch December 3, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants