-
Notifications
You must be signed in to change notification settings - Fork 35
Description
This comment is not specific to this PR but rather the extension of the existing code makes this shortcoming more clear:
This modules imports modules for MRIO sources and contains code forks - like IF statements - for handling specific sources as well. This means this module has to be updated each time a new source is being handled. This is not the best design.
We have code among the TIEM that can provide an example of a superior module design. See for instance FLOWSA's generateflowbyactivity.py. Code that is required to parse and further transform a specific source is put into a separate source module. Some of that is describing in this Wiki section.
Files here such as ceda_helpers.py and the yaml configs partially implement but do not fully implement this option. I would recommend further refactoring to mature the code to eliminate specific MRIO imports and code forks from this file.
Originally posted by @WesIngwersen in #42 (comment)