JIRA: CPOUI5FOUNDATION-1063

Open tasks:

• Removal of binding syntax attribute if compat-version=edge is currently handled in addition to the existing check. This should be streamlined and tested properly.
• Removal of duplicate attributes (identical names) + tests
• Remove Attributes: Adjust logic to remove entire line (no whitespace)
• Check existing fixtures and snapshots for correctness
• Identify missing scenarios and add test cases
  • Missing test case for removal of binding syntax attribute if compat-version=edge
  • Maybe also some more missing cases
• Implement parsing error checks (currently commented out in src/autofix/autofix.ts). This needs some investigation to find a good solution:
  • HTML is not strictly valid XML, so we can't reuse the approach for XML files
  • A separate HTML parser might be required to check for issues
  • We might use the existing XML parser approach and only check for error differences of the file before and after the autofix
  • Unit test for error handling could be done in a similar way as for XML changes:

    linter/test/lib/autofix/autofix.ts

    Line 41 in bc47a76

    class TestFix extends XmlEnabledFix {

  • Discussion on July 28: Agreed upon to omit a special HTML syntax validation since it's too vague and not very suitable for our cases -> Instead try to validate by covering as many edge cases in the tests as possible
• Check code coverage and add unit tests where applicable (e.g. for AnimationModeFix.getAnimationModeValue)
• Add test cases for unquoted attribute values (e.g. data-sap-ui-compatVersion=edge). Modifications should not fail or create invalid HTML, but it would be also fine to ignore such cases as it is unusual and rarely appears in real world projects
  • Add tests to ensure autofix doesn't break anything for these cases
• Add note to README.md
• Handle removal of duplicate attributes WITHOUT values
• Handle attributes which only have one character (e.g. a="xyz" or a)
  • Removal
  • Renaming
• Add unit tests for RemoveAttributeFix, RenameAttributeFix & AnimationModeFix
• Check Linter Diff