[CMake] fix HDF5 version number in STIRConfig.cmake - #1580
Merged
Conversation
We now only require version major.minor for HDF5, as HDF5_VERSION could otherwise contain extra patch info, causing problems with find_package(STIR). Fixes UCL#1557
KrisThielemans
force-pushed
the
CMake_HDF5_export_fix
branch
from
March 28, 2025 23:14
a8846f5 to
f49d93e
Compare
Collaborator
Author
|
One job fails due to failure to download ROOT. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now only require version major.minor for HDF5, as
HDF5_VERSIONcould otherwise contain extra patch info, causing problems withfind_package(STIR).Fixes #1557