Skip to content

Download using objectURL of a blob - #73

Merged
kba merged 3 commits into
masterfrom
download-url
Dec 11, 2017
Merged

Download using objectURL of a blob#73
kba merged 3 commits into
masterfrom
download-url

Conversation

@kba

@kba kba commented Dec 11, 2017

Copy link
Copy Markdown
Collaborator

The data-URL technique only works for reasonably short strings, this is a more robust implementation. Should work for transformations from URL and upload.

Comment thread web/ocr-fileformat.js
@@ -1,4 +1,6 @@
/* globals $ */
/* globals Blob */
/* global Prism */

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a difference between globals (as in line 2) and global (as in line 3) here?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

@stweil stweil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kba
kba merged commit 7756866 into master Dec 11, 2017
Comment thread Dockerfile
&& update-ca-certificates \
&& make install \
&& cp docker.config.php web/config.local.php \
&& sed -i '/^upload_max_filesize/ s/=.*$/= 100M' \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @kba 🔥

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Since the image sizes don't differ now, I'll sumit my dev Dockerfile later.

@stweil
stweil deleted the download-url branch December 11, 2017 13:24
@stweil

stweil commented Dec 11, 2017

Copy link
Copy Markdown
Member

I have committed a fix for Dockerfile which hopefully makes it work again.

@zuphilip zuphilip mentioned this pull request Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants