Skip to content

install page2img - #189

Merged
stweil merged 2 commits into
UB-Mannheim:masterfrom
bertsky:page2img
Apr 30, 2025
Merged

install page2img#189
stweil merged 2 commits into
UB-Mannheim:masterfrom
bertsky:page2img

Conversation

@bertsky

@bertsky bertsky commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

@stweil
stweil marked this pull request as draft April 29, 2025 12:30
@stweil

stweil commented Apr 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Merging this PR would currently break the installation. Therefore this is marked as a draft PR until the mentioned dependency is available.

stweil
stweil requested changes Apr 29, 2025
View reviewed changes

@stweil stweil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kba also suggested a different name for the new Python module. The same name must be used here, too,

@kba

kba commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

Merging this PR would currently break the installation. Therefore this is marked as a draft PR until the mentioned dependency is available.

OCR-D/format-converters#28 has been merged and published https://pypi.org/project/ocrd-format-converters/

@kba also suggested a different name for the new Python module. The same name must be used here, too,

Not really, since we're not installing from PyPI but from the submodule, which can remain called format-converters. The rename is just for the PyPI release to avoid confusion with a similarly named old project there.

@kba
kba marked this pull request as ready for review April 30, 2025 13:11
stweil
stweil approved these changes Apr 30, 2025
View reviewed changes

@stweil stweil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stweil
stweil merged commit 3540a3b into UB-Mannheim:master Apr 30, 2025
@bertsky bertsky mentioned this pull request Apr 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kba kba kba approved these changes
@stweil stweil stweil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bertsky @stweil @kba