Skip to content

Removing dev-dependency flag breaks usage with strong-named packages #66

Description

@mgravell

Version

3.0.1

Platform

(any)

Steps to reproduce

I recently tried updating from 2.4.1 to 3.0.1, which failed because

Referenced assembly 'GitHubActionsTestLogger, Version=3.0.1.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.

Since 2.4.1 also does not have a strong name, I deduce this is because of removing the dev-dependency flag, here.

I need my test project to be strong named because the library being tested is strong-named, and some of the tests requires IVTA, which requires the test assembly to be strong-named with the same key:

Friend access was granted by '(whatever), Culture=neutral, PublicKeyToken=(whatever)', but the public key of the output assembly ('') does not match that specified by the InternalsVisibleTo attribute in the granting assembly.

Suggestion: add a strong name to GitHubActionsTestLogger (probably the simplest fix), or re-add the dev-dependency flag.

Details

Expected behaviour:

  • it can be used from a strong-named test assembly

Actual behaviour:

  • it cannot

Checklist

  • I have looked through existing issues to make sure that this bug has not been reported before
  • I have provided a descriptive title for this issue
  • I have made sure that this bug is reproducible on the latest version of the package
  • I have provided all the information needed to reproduce this bug as efficiently as possible
  • I have sponsored this project

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions