Improved vertical positioning for svg text icons#3056
Merged
Gerrit0 merged 2 commits intoTypeStrong:devfrom Jan 5, 2026
Merged
Improved vertical positioning for svg text icons#3056Gerrit0 merged 2 commits intoTypeStrong:devfrom
Gerrit0 merged 2 commits intoTypeStrong:devfrom
Conversation
…ical positioning for svg text icons
kentt9484-crypto
approved these changes
Dec 27, 2025
Collaborator
|
It's a real shame that asking the browser to do this using the knowledge it has of the font in use apparently has worse results than just hardcoding a random value that looks about right... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
dominant-baseline="central"withdy="0.35em"to improve vertical positioning for svg text icons.https://developer.mozilla.org/en-US/docs/Web/SVG/Reference/Attribute/dy