Add module readmes to json output#2500
Merged
Gerrit0 merged 2 commits intoTypeStrong:masterfrom Feb 11, 2024
Merged
Conversation
Gerrit0
requested changes
Feb 11, 2024
Collaborator
Gerrit0
left a comment
Gerrit0
left a comment
There was a problem hiding this comment.
I'm fine merging this without a test update -- I don't have a good way to test packages mode as thoroughly as I'd like yet.
This was referenced Jul 27, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2499
--
This change attempts to fix the above by mimicking the behavior of the ProjectReflection json serialization, which properly outputs the json readme property.
I skimmed through the test suites, but could not find a good place to integrate a test for this at a glance. Let me know which existing tests should be updated (if needed) and where new test logic should be implemented and I'll dig into it, assuming this change in behavior is acceptable.