Skip to content

doc: add precision regarding --files option#930

Merged
blakeembrey merged 2 commits into
TypeStrong:masterfrom
ledenis:patch-1
Jan 9, 2020
Merged

doc: add precision regarding --files option#930
blakeembrey merged 2 commits into
TypeStrong:masterfrom
ledenis:patch-1

Conversation

@ledenis

@ledenis ledenis commented Dec 26, 2019

Copy link
Copy Markdown
Contributor

I suggest to add a little precision about --files options, since it does not seem very clear #782 (comment)

@coveralls

coveralls commented Dec 26, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 84.055% when pulling 12fc4b7 on ledenis:patch-1 into 2ba0a8f on TypeStrong:master.

Comment thread README.md Outdated
```

**Tip:** If you _must_ use `files`, enable `--files` flags or set `TS_NODE_FILES=true`.
**Tip:** If you _must_ use `files` or `include`/`exclude`, enable `--files` flags or set `TS_NODE_FILES=true`.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: how about this phrasing, since some people combine "files" with "include"?

If you must use files, include, or exclude, enable ...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done. Also reworded the phrase above

@blakeembrey
blakeembrey merged commit 3401f59 into TypeStrong:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants