fix(loader): new Error to webpack when errors occured in the loader f…#792
Merged
johnnyreilly merged 1 commit intoTypeStrong:masterfrom Jun 27, 2018
linxiaowu66:master
Merged
fix(loader): new Error to webpack when errors occured in the loader f…#792johnnyreilly merged 1 commit intoTypeStrong:masterfrom linxiaowu66:master
johnnyreilly merged 1 commit intoTypeStrong:masterfrom
linxiaowu66:master
Conversation
Member
|
What does the error message look like with your change? (Obviously it depends on the particular error!) |
Author
|
Error just like that: Even though we had not this error, the error info can not be printed in the console |
Member
|
Seems reasonable. I'm currently busy with a few things. When they're resolved I'll take a proper look at this. |
Author
|
ok |
|
I got the same error starting a new project and forgetting to install typescript locally. I temporarily patched index.js with @linxiaowu66 fix and it worked. I guess it will take a more generic fix, maybe stringify the error object? |
Member
|
@systemmetaphor are you suggesting a different fix or keeping the current suggestion? |
ghost
mentioned this pull request
Member
|
Going to roll with this I think - it's slightly simpler and... it was first 😄 |
Author
|
😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…unction
When using
callback(instanceOrError.error)to throw error, webpack will print :This way can not show the error message explicitly. So I change the returning value when error.
new Error(instanceOrError.error.message)