Skip to content

fix(types): expose public interfaces from root index.d.ts#790

Merged
johnnyreilly merged 1 commit intoTypeStrong:masterfrom
Hotell:mh/tweak-public-ambient-types-api
Jun 8, 2018
Merged

fix(types): expose public interfaces from root index.d.ts#790
johnnyreilly merged 1 commit intoTypeStrong:masterfrom
Hotell:mh/tweak-public-ambient-types-api

Conversation

@Hotell
Copy link
Copy Markdown
Contributor

@Hotell Hotell commented Jun 8, 2018

this tweaks #788 by exposing proper public types API from root index.d.ts so consumer doesn't have to traverse private package path to access interfaces.

before

// @ts-check
const tsLoaderOptionsRules = /** @type {import('ts-loader/dist/types/interfaces').LoaderOptions}*/ ({
  configFile: tsConfig,
  transpileOnly: true
})

after

// @ts-check
const tsLoaderOptionsRules = /** @type {import('ts-loader').Options}*/ ({
  configFile: tsConfig,
  transpileOnly: true
})

@johnnyreilly
Copy link
Copy Markdown
Member

johnnyreilly commented Jun 8, 2018

Great - thanks! Will try and push this out soon. I appreciate your work ♥️🌻

@johnnyreilly johnnyreilly merged commit 3a61d4b into TypeStrong:master Jun 8, 2018
@Hotell Hotell deleted the mh/tweak-public-ambient-types-api branch June 8, 2018 19:36
@Hotell
Copy link
Copy Markdown
Contributor Author

Hotell commented Jun 8, 2018

Yo @johnnyreilly you're more than welcome man! sorry I didn't include this in former PR. thanks for merging ! cheers

@johnnyreilly
Copy link
Copy Markdown
Member

johnnyreilly commented Jun 8, 2018

No worries - released with https://github.com/TypeStrong/ts-loader/releases/tag/v4.4.1

@johnnyreilly johnnyreilly mentioned this pull request Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hotell @johnnyreilly