Do not create program multiple times when there are no changes in files#747
Merged
johnnyreilly merged 1 commit intoTypeStrong:masterfrom Mar 17, 2018
sheetalkamat:moduleResolution
Merged
Do not create program multiple times when there are no changes in files#747johnnyreilly merged 1 commit intoTypeStrong:masterfrom sheetalkamat:moduleResolution
johnnyreilly merged 1 commit intoTypeStrong:masterfrom
sheetalkamat:moduleResolution
Conversation
TypeScript cant tell if there is invalidation because of custom module resolution, that means it needs to create new program whenver asked for Fixes #746
Member
|
Thanks @sheetalkamat! I'll take a look |
Member
|
Thanks @sheetalkamat! This will ship with the next release of ts-loader. And thanks @MLoughry for providing a repro! 🌻 |
Member
|
Released with 4.1.0 |
This was referenced Mar 19, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript cant tell if there is invalidation because of custom module resolution, that means it needs to create new program whenver asked for
Fixes #746