feat: getCustomTransformers support path string for a module#745
Merged
johnnyreilly merged 2 commits intoTypeStrong:masterfrom Mar 17, 2018
vagusX:master
Merged
feat: getCustomTransformers support path string for a module#745johnnyreilly merged 2 commits intoTypeStrong:masterfrom vagusX:master
getCustomTransformers support path string for a module#745johnnyreilly merged 2 commits intoTypeStrong:masterfrom
vagusX:master
Conversation
Member
|
This is terrific! Thanks so much :-) would you be able to update the readme with example usage details please? Hopefully we can use that to create a second variant of the https://github.com/TypeStrong/ts-loader/tree/master/test/comparison-tests/customTransformer existing test |
Contributor
Author
|
@johnnyreilly ok, I will update it asap. |
Contributor
Author
|
@johnnyreilly I've finish those jobs. You can review it where you happen to be free |
Member
|
Thanks @vagusX! Will take a look this weekend I hope |
Member
|
Thanks! Will ship with the next release of ts-loader |
Member
|
Released with 4.1.0 |
This was referenced Mar 19, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With happyPackMode, the customTransformers cannot be passed as undering different process.
Workaround: pass a path string to locate a js module file which export a function return the customTransformers.
Same strategy as https://github.com/s-panferov/awesome-typescript-loader/pull/531/files
Related #739