Initial implementation of trace for traceResolution in #691 by onigoetz · Pull Request #721 · TypeStrong/ts-loader

onigoetz · 2018-02-07T18:54:12Z

Hi,

sorry for the long time between the initial discussion and the pull request. I tried to do the first implementation for issue #691

I tried to write a test but could not. When running them it gets stuck at the first test:

Uncaught AssertionError [ERR_ASSERTION]: patch0/output.txt is different between actual and expected
      + expected - actual

           Asset     Size  Chunks             Chunk Names
       bundle.js   A-NUMBER-OF kB       0  [emitted]  main
      -   [0] ./.test/aliasResolution/app.ts A-NUMBER-OF bytes {0} [built]
      +   [0] ./.test/aliasResolution/app.ts A-NUMBER-OF bytes {0}
          [1] ./.test/aliasResolution/common/components/myComponent.ts A-NUMBER-OF bytes {0} [built]

johnnyreilly · 2018-02-07T19:29:31Z

That's fine - talk to me how this would be used / what output you expect to see when you are using it.

Let's see if I can help you.

johnnyreilly · 2018-02-07T19:34:01Z

My guess is we can clone an existing test (aliasResolution perhaps), call it traceResolution perhaps.

Then:

set the traceResolution: true in the tests tsconfig.json
delete all expected output
follow the instructions to generate a single test output (see here: https://github.com/TypeStrong/ts-loader/blob/master/test/comparison-tests/README.md )

onigoetz · 2018-02-07T20:33:19Z

Sooo, I did it .. good news is your instructions worked like a charm. Bad news, the stdout isn't stored in the expected output.

Also, the full path to the files is in the logs, which makes them un-reproducible.

What can I do to make it write the output to output.txt and automatically replace absolute paths ?

The Full output I get is the following :

Expected output redirected to stdout

======== Resolving type reference directive 'braces', containing file '/Users/onigoetz/Sites/Library/ts-loader/__inferred type names__.ts', root directory '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types'. ========
Resolving with primary search path '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types'.
'package.json' does not have a 'typings' field.
'package.json' does not have a 'types' field.
'package.json' has 'main' field '' that references '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/braces'.
Found 'package.json' at '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/braces/package.json'. Package ID is '@types/braces/[email protected]'.
'package.json' does not have a 'typings' field.
'package.json' does not have a 'types' field.
File '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/braces/index.d.ts' exist - use it as a name resolution result.
Resolving real path for '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/braces/index.d.ts', result '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/braces/index.d.ts'.
======== Type reference directive 'braces' was successfully resolved to '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/braces/index.d.ts', primary: true. ========
======== Resolving type reference directive 'micromatch', containing file '/Users/onigoetz/Sites/Library/ts-loader/__inferred type names__.ts', root directory '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types'.========
Resolving with primary search path '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types'.
'package.json' does not have a 'typings' field.
'package.json' does not have a 'types' field.
'package.json' has 'main' field '' that references '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/micromatch'.
Found 'package.json' at '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/micromatch/package.json'. Package ID is '@types/micromatch/[email protected]'.
'package.json' does not have a 'typings' field.
'package.json' does not have a 'types' field.
File '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/micromatch/index.d.ts' exist - use it as a name resolution result.
Resolving real path for '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/micromatch/index.d.ts', result '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/micromatch/index.d.ts'.
======== Type reference directive 'micromatch' was successfully resolved to '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/micromatch/index.d.ts', primary: true. ========
======== Resolving type reference directive 'semver', containing file '/Users/onigoetz/Sites/Library/ts-loader/__inferred type names__.ts', root directory '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types'. ========
Resolving with primary search path '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types'.
'package.json' does not have a 'typings' field.
'package.json' does not have a 'types' field.
'package.json' has 'main' field '' that references '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/semver'.
Found 'package.json' at '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/semver/package.json'. Package ID is '@types/semver/[email protected]'.
'package.json' does not have a 'typings' field.
'package.json' does not have a 'types' field.
File '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/semver/index.d.ts' exist - use it as a name resolution result.
Resolving real path for '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/semver/index.d.ts', result '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/semver/index.d.ts'.
======== Type reference directive 'semver' was successfully resolved to '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/semver/index.d.ts', primary: true. ========
======== Resolving module 'braces' from '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/micromatch/index.d.ts'. ========
Module resolution kind is not specified, using 'NodeJs'.
Loading module 'braces' from 'node_modules' folder, target file type 'TypeScript'.
Directory '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/micromatch/node_modules' does not exist, skipping all lookups in it.
Directory '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/node_modules' does not exist, skipping all lookups in it.
'package.json' does not have a 'typings' field.
'package.json' does not have a 'types' field.
'package.json' has 'main' field 'index.js' that references '/Users/onigoetz/Sites/Library/ts-loader/node_modules/braces/index.js'.
Found 'package.json' at '/Users/onigoetz/Sites/Library/ts-loader/node_modules/braces/package.json'. Package ID is 'braces/[email protected]'.
File '/Users/onigoetz/Sites/Library/ts-loader/node_modules/braces.ts' does not exist.
File '/Users/onigoetz/Sites/Library/ts-loader/node_modules/braces.tsx' does not exist.
File '/Users/onigoetz/Sites/Library/ts-loader/node_modules/braces.d.ts' does not exist.
'package.json' does not have a 'typings' field.
'package.json' does not have a 'types' field.
File '/Users/onigoetz/Sites/Library/ts-loader/node_modules/braces/index.ts' does not exist.
File '/Users/onigoetz/Sites/Library/ts-loader/node_modules/braces/index.tsx' does not exist.
File '/Users/onigoetz/Sites/Library/ts-loader/node_modules/braces/index.d.ts' does not exist.
'package.json' does not have a 'typings' field.
'package.json' does not have a 'types' field.
'package.json' has 'main' field '' that references '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/braces'.
Found 'package.json' at '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/braces/package.json'. Package ID is '@types/braces/[email protected]'.
File '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/braces.d.ts' does not exist.
'package.json' does not have a 'typings' field.
'package.json' does not have a 'types' field.
File '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/braces/index.d.ts' exist - use it as a name resolution result.
Resolving real path for '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/braces/index.d.ts', result '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/braces/index.d.ts'.
======== Module name 'braces' was successfully resolved to '/Users/onigoetz/Sites/Library/ts-loader/node_modules/@types/braces/index.d.ts'. ========

johnnyreilly · 2018-02-07T20:44:37Z

Oh wow. Yeah - that makes sense. Bottom line, this is a 1 line change - it doesn't break existing tests and it adds functionality. Merged.

onigoetz · 2018-02-07T20:45:56Z

Oh, thanks :) That was fast

johnnyreilly · 2018-02-07T21:16:07Z

Released with v3.5.0: https://github.com/TypeStrong/ts-loader/releases/tag/v3.5.0

Initial implementation of trace for traceResolution #691

5bd6d43

johnnyreilly merged commit af75ecb into TypeStrong:master Feb 7, 2018

onigoetz mentioned this pull request Feb 7, 2018

Add trace method to servicesHost #691

Closed

ghost mentioned this pull request Feb 21, 2018

Update 17 dependencies from npm storybookjs/storybook#3050

Merged

This was referenced Mar 19, 2018

Bump ts-loader from 2.3.4 to 4.1.0 fcknutwil/sponsorencrm_client#48

Closed

Bump ts-loader from 3.2.0 to 4.1.0 Armour/express-webpack-react-redux-typescript-boilerplate#221

Closed

Bump ts-loader from 3.2.0 to 4.1.0 jamesabels/mithril-bp#91

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Initial implementation of trace for traceResolution in #691#721

Initial implementation of trace for traceResolution in #691#721
johnnyreilly merged 1 commit intoTypeStrong:masterfrom
onigoetz:master

onigoetz commented Feb 7, 2018

Uh oh!

johnnyreilly commented Feb 7, 2018

Uh oh!

johnnyreilly commented Feb 7, 2018

Uh oh!

onigoetz commented Feb 7, 2018

Uh oh!

johnnyreilly commented Feb 7, 2018

Uh oh!

onigoetz commented Feb 7, 2018

Uh oh!

johnnyreilly commented Feb 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

onigoetz commented Feb 7, 2018

Uh oh!

johnnyreilly commented Feb 7, 2018

Uh oh!

johnnyreilly commented Feb 7, 2018

Uh oh!

onigoetz commented Feb 7, 2018

Uh oh!

johnnyreilly commented Feb 7, 2018

Uh oh!

onigoetz commented Feb 7, 2018

Uh oh!

johnnyreilly commented Feb 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants