Fix none-node_module imports of built ts files#674
Merged
johnnyreilly merged 1 commit intoTypeStrong:masterfrom Oct 29, 2017
Merged
Fix none-node_module imports of built ts files#674johnnyreilly merged 1 commit intoTypeStrong:masterfrom
johnnyreilly merged 1 commit intoTypeStrong:masterfrom
Conversation
Member
|
This looks good! It's a minor change and the existing tests still pass with it which is good. Generally it's good to have a test to cover changed behaviour to prevent regressions in the future. I think it makes sense to merge and when I release this I'll keep my eyes open for anyone having issues. Hopefully there won't be any. Thanks so much for drilling into this and coming up with a solution! |
Member
|
Published with 3.1.1 - thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #667