Fix allowJs @types error#658
Merged
johnnyreilly merged 9 commits intoTypeStrong:masterfrom Oct 18, 2017
johnnyreilly:master
Merged
Fix allowJs @types error#658johnnyreilly merged 9 commits intoTypeStrong:masterfrom johnnyreilly:master
johnnyreilly merged 9 commits intoTypeStrong:masterfrom
johnnyreilly:master
Conversation
johnnyreilly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #657 #655 for TypeScript 2.4+
Added nodeResolutionAllowJs test to cover this. Use a strategy approach as the amend seems to break @types resolution in some way. Essentially, 2.4+ will run with a new approach for resolution and 2.3 will run with the existing approach.
We'll probably drop TypeScript 2.3 and below support when ts-loader 4.0 ships.