Skip to content

Revert #621 changes#627

Merged
johnnyreilly merged 1 commit intoTypeStrong:masterfrom
loilo:revert-621
Sep 7, 2017
Merged

Revert #621 changes#627
johnnyreilly merged 1 commit intoTypeStrong:masterfrom
loilo:revert-621

Conversation

@loilo
Copy link
Copy Markdown
Contributor

@loilo loilo commented Sep 7, 2017 •
edited
Loading

Reverts changes of #621 since they were flawed by design.

git revert --no-commit 7f8e783
git revert --no-commit d5f182f
git commit -m "Revert #621 changes"

@loilo loilo mentioned this pull request Sep 7, 2017
Closed
@johnnyreilly
Copy link
Copy Markdown
Member

johnnyreilly commented Sep 7, 2017

Great. I should be at a computer within the hour. Assuming all is good I'll look to ship this as 2.3.6

@loilo loilo mentioned this pull request Sep 7, 2017
Closed
@loilo
Copy link
Copy Markdown
Contributor Author

loilo commented Sep 7, 2017 •
edited
Loading

Hm. Seems that the CI builds failed at the tests this PR removed. That's weird.

May I have overlooked something?

@johnnyreilly
Copy link
Copy Markdown
Member

johnnyreilly commented Sep 7, 2017

Weirdly it seems to be failing on the test that your PR removes? Odd

@johnnyreilly
Copy link
Copy Markdown
Member

johnnyreilly commented Sep 7, 2017

I'm going take a gamble on this

@johnnyreilly johnnyreilly merged commit bd7c0da into TypeStrong:master Sep 7, 2017
@loilo
Copy link
Copy Markdown
Contributor Author

loilo commented Sep 7, 2017 •
edited
Loading

I guess/hope it's fine. The builds seemed to fail only on the removed tests. Even more strange that they only failed for two TS versions (1.7 and 2.5).

Seems like some kind of weird caching issue to me but I doubt that those "simple" bugs are still around in those established CI tools.

¯\_(ツ)_/¯

@johnnyreilly
Copy link
Copy Markdown
Member

johnnyreilly commented Sep 7, 2017

Problem was to do with some of the test files still hanging around (no idea why). Should now be gone. Just running tests locally now...

@loilo loilo deleted the revert-621 branch September 7, 2017 08:40
@johnnyreilly
Copy link
Copy Markdown
Member

johnnyreilly commented Sep 7, 2017

2.3.6 has shipped!

@loilo
Copy link
Copy Markdown
Contributor Author

loilo commented Sep 7, 2017

Great. Thanks for your patience!

@johnnyreilly
Copy link
Copy Markdown
Member

johnnyreilly commented Sep 7, 2017

No worries - all is good now; thanks for the PR! 👍 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loilo @johnnyreilly