Add configFile option#607
Add configFile option#607johnnyreilly merged 1 commit intoTypeStrong:masterfrom loilo:config-file-option
configFile option#607Conversation
This deprecates the `configFileName` option and renames it to `configFile`. It keeps its user-facing behaviour, improving some path resolutions under the hood. Using the `configFileName` option will now raise a `logWarning` in the console.
|
Thanks! I'll try and take a look this weekend. Tests pass! |
|
Brilliant - thanks! |
|
shipped with v2.3.4 - thanks for your help! |
|
My pleasure. 🙃 |
|
So cool, electron-webpack uses ts-loader in the user projects and in any case have to find tsconfig (and set to fork-ts-checker-webpack-plugin if need, option |
|
@develar Glad that it helped. I'm still wondering if this option could need an additional per-entry-point configurability, something like this: configFile: {
'*': 'tsconfig.json', // ← default value
'named-entry-point-a': '/var/www/tsconfig.json',
'named-entry-point-b': 'wildly-different-name.json'
}Before possibly opening an issue about this, what do you @develar as an experienced |
|
@loilo I think it is not required. Currently, we use one tsconfig.json for both parts (Electron app consists of two parts — code for renderer process and code for main process). I cannot imagine when it can be required :) |
|
Okay, thanks for your feedback – I guess then I could go deeper in thinking about this instead. |
This deprecates the
configFileNameoption and renames it toconfigFile.It keeps its user-facing behaviour, improving some path resolutions under the hood.
Using the
configFileNameoption will now raise alogWarningin the console.