Use compiler.fileTimestamps cause watcher may be null#587
Use compiler.fileTimestamps cause watcher may be null#587johnnyreilly merged 2 commits intoTypeStrong:masterfrom
Conversation
912be01 to
85f21e3
Compare
|
Thanks for contributing! Do you know if this an official part of the API? I ask as we've had that happen before; see here: Could you check please? @sokra may know.. |
|
Does |
It's atm the same, but it depends on the implementation of the watcher. The results of watcher.getTimes() are stored in fileTimestamps. See here and here. In case of the WatchIgnorePlugin it contains more data, as WatchIgnorePlugin enhances the timestamps with all ignored files. Performance isn't really a topic.
|
|
Thanks @zinserjan - that's really helpful. I've been asking in the webpack slack channel to see if there's any reason not to go with this. No-one has advised that's the case so far. If no-one has given a compelling reason why we shouldn't take this in the next 24 hours then I reckon we're good to merge. Thanks for the contribution by the way, we really appreciate it! 🌻 |
|
@sokra (the creator of webpack) has just confirmed this should be safe so I plan to merge. Thanks for the PR! |
|
@johnnyreilly awesome! |
|
Released with v2.3.1 - thanks again! https://github.com/TypeStrong/ts-loader/releases/tag/v2.3.1 |
fixes #585