Skip to content

Speculative fix for #568#569

Merged
johnnyreilly merged 2 commits intoTypeStrong:masterfrom
johnnyreilly:master
Jul 1, 2017
Merged

Speculative fix for #568#569
johnnyreilly merged 2 commits intoTypeStrong:masterfrom
johnnyreilly:master

Conversation

@johnnyreilly
Copy link
Copy Markdown
Member

No description provided.

…ly mode

Not useful for when using ts-loader with fork-ts-checker-webpack-plugin.  Can still be set manually with tsconfig.json if desired and so arguably not a breaking change
@johnnyreilly
Copy link
Copy Markdown
Member Author

@donaldpipowitch I've included the change we discussed about dropping this piece of code:

        // do any necessary config massaging		
        if (loaderOptions.transpileOnly) {		
            configFile.config.compilerOptions.isolatedModules = true;		
        }

This can still be set via tsconfig.json if desired. It just won't be set by default anymore (since it's not useful with fork-ts-checker-webpack-plugin in the mix anyway)

@donaldpipowitch
Copy link
Copy Markdown
Contributor

Thank you for pinging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants