Skip to content

Track timestamps to filter changed files.#500

Merged
johnnyreilly merged 2 commits intoTypeStrong:masterfrom
WearyMonkey:changed-file-tracking
Mar 16, 2017
Merged

Track timestamps to filter changed files.#500
johnnyreilly merged 2 commits intoTypeStrong:masterfrom
WearyMonkey:changed-file-tracking

Conversation

@WearyMonkey
Copy link
Copy Markdown
Contributor

@WearyMonkey WearyMonkey commented Mar 14, 2017

getTimes() returns a map with all files. This breaks version tracking as all file versions are incremented.

This PR adds manual timestamp tracking to filter out actually changed files.

@WearyMonkey WearyMonkey mentioned this pull request Mar 14, 2017
Merged
@johnnyreilly
Copy link
Copy Markdown
Member

johnnyreilly commented Mar 14, 2017

Thanks! Let's see how the tests do. Also @jbrantly would you be able to comment on this? Seems like a reasonable change to me.

@WearyMonkey I'm probably about to go offline - ping me tomorrow if it looks like I've forgotten about this.

@johnnyreilly
Copy link
Copy Markdown
Member

johnnyreilly commented Mar 15, 2017

Okay the failing tests are issue441 and importsWatch - i think the failures are reasonable and expected given the changed behaviour this will introduce. Do you want to regenerate the 2.2 test output for these tests? You might need to delete the existing output manually before you do this; it doesn't always clean up entirely. If memory serves you'll need to do something like npm run comparison-tests -- --save-output --single-test issue441 etc

@johnnyreilly johnnyreilly mentioned this pull request Mar 16, 2017
Closed
@johnnyreilly
Copy link
Copy Markdown
Member

johnnyreilly commented Mar 16, 2017

Just had a go at regenerating the test data myself. I didn't realise I could work directly on a supplied PR before I'd landed it. Pleased to see I can 😄

@johnnyreilly johnnyreilly merged commit 44a2cdb into TypeStrong:master Mar 16, 2017
@johnnyreilly
Copy link
Copy Markdown
Member

johnnyreilly commented Mar 16, 2017

Merged - will look to cut a release tonight if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WearyMonkey @johnnyreilly