Skip to content

Fix TS module resolution paths on Windows#373

Merged
johnnyreilly merged 3 commits intoTypeStrong:masterfrom
smphhh:issue372
Nov 14, 2016
Merged

Fix TS module resolution paths on Windows#373
johnnyreilly merged 3 commits intoTypeStrong:masterfrom
smphhh:issue372

Conversation

@smphhh
Copy link
Copy Markdown
Contributor

@smphhh smphhh commented Nov 14, 2016

Normalizes paths returned by TS module resolution to fix duplicate dependency issue #372 on Windows.

@johnnyreilly
Copy link
Copy Markdown
Member

Thanks for contributing! Is this ready for review or are you still working on it?

@smphhh
Copy link
Copy Markdown
Contributor Author

smphhh commented Nov 14, 2016

It's ready.

@johnnyreilly
Copy link
Copy Markdown
Member

Great - I'll take a look when I get a moment

@smphhh
Copy link
Copy Markdown
Contributor Author

smphhh commented Nov 14, 2016

In one of my projects this change cut the incremental build time for a small change in the entry file from 3.5 seconds to just under one second.

@johnnyreilly
Copy link
Copy Markdown
Member

Sweet!

@johnnyreilly johnnyreilly merged commit 734f536 into TypeStrong:master Nov 14, 2016
@johnnyreilly
Copy link
Copy Markdown
Member

Thanks - this is great! This will ship as part of the next release.

@smphhh
Copy link
Copy Markdown
Contributor Author

smphhh commented Nov 14, 2016

Thanks for the quick pull :)

@johnnyreilly
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants