Skip to content

The big refactor#343

Merged
johnnyreilly merged 23 commits intoTypeStrong:masterfrom
johnnyreilly:master
Nov 1, 2016
Merged

The big refactor#343
johnnyreilly merged 23 commits intoTypeStrong:masterfrom
johnnyreilly:master

Conversation

@johnnyreilly
Copy link
Copy Markdown
Member

No description provided.

@johnnyreilly
Copy link
Copy Markdown
Member Author

Hey @jbrantly, Re: #335

I think I've reached the end of my initial refactor. Despite initial appearances, it's pretty much the code as was (right down to the comments; all intact). It's just been split out into a bunch of modules and hopefully that aids comprehension (it helps mine).

It's written using TS 2.0 and all the tests are passing.

My plan is to merge this and use this as the new base for ts-loader 1.x. I'd ship a beta of this initially just to make sure there's no undiscovered gremlins in my changes and then, all being well, look to ship 1.0 proper.

Before all that begins I wanted to give you the chance to express a view on the refactor; any problems / preferences from your point of view?

@johnnyreilly johnnyreilly changed the title Started refactor again The big refactor Oct 30, 2016
@johnnyreilly
Copy link
Copy Markdown
Member Author

This has now been published to npm as 1.0.0-beta-1. If anyone wants to give it a whirl it should just work ™️

@johnnyreilly
Copy link
Copy Markdown
Member Author

I'm presently testing this on projects of my own. All good so far. Will look to merge / release later this week if all still good.

optimise formatErrors
Fix test data for errors test
@johnnyreilly johnnyreilly merged commit 66d02a8 into TypeStrong:master Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant