fix: times is not iterable bug#1290
Conversation
|
Under what circumstances would |
|
For webpack@5 middlewares usage: const webpack = require('webpack');
const middleware = require('webpack-dev-middleware');
const compiler = webpack({
// webpack options
});
console.log(compiler.fileTimestamps);
// Output:
// webpack@4: Map(0) {}
// webpack@5: undefined |
|
Interesting - has |
|
Yes with FileSystemInfo and the snapshot system. Avoid comparing timestamps directly and use a snapshot instead |
@elf-mouse would you care to take a look at @sokra's suggestion around migrating to use these APIs instead? This feels like a better approach. |
|
Hi @johnnyreilly , It is recommended to update the patch first to fix this bug to ensure online security. I would migrate to use new APIs when I have time later. THX~ |
|
Thanks @elf-mouse - but I'm not very keen on the current workaround; going for the new APIs feels like the better approach. |
|
do I understand correctly that the only workaround for now is not to use webpack 5? |
|
If someone would like to create a minimal reproduction repo that illustrates this issue, it might help people to work on this. |
There is a simple example: Any progress in fixing this issue? |
|
This error seems to have popped out of nowhere for me. Have been using Next / webpack 5 for a while and previously compiled fine. |
|
If someone would like to submit a PR which makes use of the advice provided by @sokra we'll happily take a look:
|
No description provided.