Speeds up project reference build and doesnt store the result in memory#1202
Merged
johnnyreilly merged 6 commits intomasterfrom Oct 24, 2020
Merged
Speeds up project reference build and doesnt store the result in memory#1202johnnyreilly merged 6 commits intomasterfrom
johnnyreilly merged 6 commits intomasterfrom
Conversation
Member
|
This is amazing work @sheetalkamat! Thank you! I've added this to the I'll plan to publish this later today assuming the build plays nice. Thank you so much! |
This was referenced Oct 26, 2020
Contributor
|
This has actually resulted in a huge perf regression in our builds. Now all incremental builds are as slow as clean builds(~3 minutes). Is there any debugging logs I can gather - I don't really want to blindly submit a non-actionable bug since this doesn't repo in a small test repo. |
This was referenced Mar 11, 2021
chore(deps): bump ts-loader from 6.2.2 to 8.0.18 in /OngekiScoreLog
project-primera/ongeki-score#357
Closed
This was referenced Mar 12, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the project references output files are no more in memory but have to be written to disk in order for webpack to handle symlinks, we dont need in memory read and cache of input/output files from project references. They are on disk and handled it that way.
This speeds up upto-date check to behave just like what
tsc -bwould do so that we are not reading files in memory.This was done as part of investigation for a team who was running into OOM and slower builds on huge project.