update GitHub Actions#1144
update GitHub Actions#1144johnnyreilly merged 18 commits intoTypeStrong:masterfrom g-plane:github-actions
Conversation
|
All tests which ran on GitHub Actions passed. AppVeyor and Travis CI won't succeed because I've deleted their configuration files. |
|
Nice work! Could you undelete the Travis and AppVeyor files please? I'd like to run them side by side for a while before decommissioning (though I'll probably not require them to pass before merging; just interested in looking at the difference) |
|
I will. While this question is not related to this PR, are there any plans for migrating the comparison tests to snapshot tests with Jest? |
Great question! I've long pondered doing something like that. It looks like webpack uses jest: I guess the problems to solve here are:
If you wanted to take a look, we'd greatly appreciate it! 🌻❤️ |
|
Yes, I know. And, can this PR be merged? |
|
Nice work! Thank you 😄 Assuming all goes well we'll look to drop AppVeyor soon |
Switched to GitHub Actions.